Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temperature to units and have units aware EOS #47

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add temperature to units and have units aware EOS #47

merged 6 commits into from
Jan 22, 2025

Conversation

adamdempsey90
Copy link
Collaborator

@adamdempsey90 adamdempsey90 commented Jan 18, 2025 •
edited
Loading

Background

This does a few things:

  • adds the missing temperature specifier for our units. That shouldn't change anything.
  • Makes singularity-eos aware of our unit system so that it's on par with singularity-opac.

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

pdmullen
pdmullen reviewed Jan 21, 2025
View reviewed changes
src/utils/units.cpp Outdated Show resolved Hide resolved
@adamdempsey90 adamdempsey90 merged commit 4a4f0f3 into develop Jan 22, 2025
4 checks passed
@adamdempsey90 adamdempsey90 deleted the dempsey/units branch January 22, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdempsey90 @pdmullen